A question on how to submit code back. I have back ported some of
your changes on the 0.11 branch back to 0.10. Specifically the code
dealing with Postgres (bug #333 and #3026) . Also I have corrected
some issues that others have had with posting comments. Just today I
also added the ability to send emails when a new review is created,
matches bug #3214 (in beta, still needs some work).
Just need to know how you want the changes given back, patch file,
checkout from SVN, etc.
> A question on how to submit code back. I have back ported some of
> your changes on the 0.11 branch back to 0.10. Specifically the code
> dealing with Postgres (bug #333 and #3026) . Also I have corrected
> some issues that others have had with posting comments. Just today I
> also added the ability to send emails when a new review is created,
> matches bug #3214 (in beta, still needs some work).
> Just need to know how you want the changes given back, patch file,
> checkout from SVN, etc.
Josh, Attached is the diff of peerReviewNew.py. This is a rough first cut at the email functionality. Right now it is a little specific for my sites needs. Like, we use NIS to login to Trac so to email any one I just need to append our email domain, the email messages are tailored to our process, etc.
I added a couple of config file options under a codereview header: - smtpserver - email_domain
For now the email messages are embedded into the code. I'd like to change that to be somehow configurable any suggestions?
On Fri, Jun 27, 2008 at 3:48 PM, Josh <jrgel...@gmail.com> wrote:
> I would like to see how you immplemented the e-mail functionality. Can > you post it as a patch or diff here?
> On 21 Jun, 21:25, TAReed <tar...@gmail.com> wrote: > > A question on how to submit code back. I have back ported some of > > your changes on the 0.11 branch back to 0.10. Specifically the code > > dealing with Postgres (bug #333 and #3026) . Also I have corrected > > some issues that others have had with posting comments. Just today I > > also added the ability to send emails when a new review is created, > > matches bug #3214 (in beta, still needs some work).
> > Just need to know how you want the changes given back, patch file, > > checkout from SVN, etc.
On Jun 22, 2:25 am, TAReed <tar...@gmail.com> wrote:
> A question on how to submit code back. I have back ported some of
> your changes on the 0.11 branch back to 0.10. Specifically the code
> dealing with Postgres (bug #333 and #3026) . Also I have corrected
> some issues that others have had with posting comments. Just today I
> also added the ability to send emails when a new review is created,
> matches bug #3214 (in beta, still needs some work).
> Just need to know how you want the changes given back, patch file,
> checkout from SVN, etc.
> Thanks,
> Tim
Thanks for that, really appreciate that! TBH I don't really have time
right now to support both 0.10 and 0.11. But i definitely can merge
that with your patches.
Please send me that new email stuff as well, I'll have a look at it.
If it is a generic solution I will definitely merge it to 0.11 as
well.
> Josh,
> Attached is the diff of peerReviewNew.py. This is a rough first cut at
> the email functionality. Right now it is a little specific for my sites
> needs. Like, we use NIS to login to Trac so to email any one I just need to
> append our email domain, the email messages are tailored to our process,
> etc.
> I added a couple of config file options under a codereview header:
> - smtpserver
> - email_domain
> For now the email messages are embedded into the code. I'd like to change
> that to be somehow configurable any suggestions?
> Please review and comment!
> Thank you,
> Tim
I had a quick look at it. It's ok, for the release version it would
definitely need templating. On the other hand I'd like to re-use any
existing functionality and there is already a mechanism for sending
emails within Trac. See NotifyEmail class and TicketNotifyEmail class
as examples. It would just need extending.
OK I'll take a look at making my changes more consistent with Trac. I should have looked into that to begin with. Once I get those changes I'll attach a diff to this thread.
On Mon, Jun 30, 2008 at 4:08 AM, proofek <proo...@gmail.com> wrote:
> Hi Tim,
> On Jun 28, 12:54 pm, "Timothy Reed" <tar...@gmail.com> wrote: > > Josh, > > Attached is the diff of peerReviewNew.py. This is a rough first cut at > > the email functionality. Right now it is a little specific for my sites > > needs. Like, we use NIS to login to Trac so to email any one I just need > to > > append our email domain, the email messages are tailored to our process, > > etc.
> > I added a couple of config file options under a codereview header: > > - smtpserver > > - email_domain
> > For now the email messages are embedded into the code. I'd like to > change > > that to be somehow configurable any suggestions?
> > Please review and comment!
> > Thank you, > > Tim
> I had a quick look at it. It's ok, for the release version it would > definitely need templating. On the other hand I'd like to re-use any > existing functionality and there is already a mechanism for sending > emails within Trac. See NotifyEmail class and TicketNotifyEmail class > as examples. It would just need extending.
