Google Mail Calendar Documents Reader Web more »
Recently Visited Groups | Help | Sign in
Google Groups Home
low pro "too much recursion"
There are currently too many topics in this group that display first. To make this topic appear first, remove this option from another topic.
There was an error processing your request. Please try again.
flag
  8 messages - Collapse all  -  Translate all to Translated (View all originals)
The group you are posting to is a Usenet group. Messages posted to this group will make your email address visible to anyone on the Internet.
Your reply message has not been sent.
Your post was successful
 
From:
To:
Cc:
Follow-up To:
Add Cc | Add Follow-up to | Edit Subject
Subject:
Validation:
For verification purposes please type the characters you see in the picture below or the numbers you hear by clicking the accessibility icon. Listen and type the numbers that you hear
 
Ro  
View profile   Translate to Translated (View Original)
 More options 1 May, 16:28
From: Ro <rohittriv...@gmail.com>
Date: Fri, 1 May 2009 08:28:24 -0700 (PDT)
Local: Fri 1 May 2009 16:28
Subject: low pro "too much recursion"
Hi
I have a really nast "too much recursion" bug..

I have a really large table in my page, and, when I scroll to the
bottom of the table - whenever I hover over a <tr> element, Firefox
throws an error at:

too much recursion
[Break on this error] if (observer.call(this, event) === false) {

which is in this function in lowpro.js: (line 165)

<code>
 _wrapObserver: function(observer) {
    return function(event) {
      if (observer.call(this, event) === false) event.stop();
    }
  }
</code>

In IE6 - the browser just crashes. I can't upgrade to IE7 - since I
work for a soul-less investment bank and we are all on IE6

If anyone can shed any light on this that would be great - It
definitely has something to do with large tables though..


    Reply to author    Forward  
You must Sign in before you can post messages.
To post a message, you must first join this group.
Please update your nickname on the subscription settings page before posting.
You do not have the permission required to post.
MRoderick  
View profile   Translate to Translated (View Original)
 More options 2 May, 10:18
From: MRoderick <roderick.mor...@gmail.com>
Date: Sat, 2 May 2009 02:18:47 -0700 (PDT)
Local: Sat 2 May 2009 10:18
Subject: Re: low pro "too much recursion"
Some samples of your code and html would probably go a long way
towards getting some kind of help with identifying the issue.

    Reply to author    Forward  
You must Sign in before you can post messages.
To post a message, you must first join this group.
Please update your nickname on the subscription settings page before posting.
You do not have the permission required to post.
Ro  
View profile   Translate to Translated (View Original)
 More options 5 May, 12:44
From: Ro <rohittriv...@gmail.com>
Date: Tue, 5 May 2009 04:44:26 -0700 (PDT)
Local: Tues 5 May 2009 12:44
Subject: Re: low pro "too much recursion"
Good point.

It seems to be calling the _wrapObserver method,
then most of the time, it goes into the method:

Event.addBehavior({
        'tr:mouseover' : function(e) {
                $(this).addClassName('hover');
        },
        'tr:mouseout' : function(e) {
                $(this).removeClassName('hover');
        }

});

however, for large tables, at the bottom of the table, it doesn't get
through to this, and throws a "too much recursion" error..

On 2 May, 10:18, MRoderick <roderick.mor...@gmail.com> wrote:


    Reply to author    Forward  
You must Sign in before you can post messages.
To post a message, you must first join this group.
Please update your nickname on the subscription settings page before posting.
You do not have the permission required to post.
Ro  
View profile   Translate to Translated (View Original)
 More options 5 May, 16:26
From: Ro <rohittriv...@gmail.com>
Date: Tue, 5 May 2009 08:26:08 -0700 (PDT)
Local: Tues 5 May 2009 16:26
Subject: Re: low pro "too much recursion"
Ok - I think I have found the issue.
In lowpro.js, when it's ovverrideing the prototype extend method, and
adding observers to elements, it runs the load method - which is
defined as thus:

Object.extend(Event.addBehavior, {
  rules : {}, cache : [],
  reassignAfterAjax : false,
  autoTrigger : true,

  load : function(rules) {
    for (var selector in rules) {
      var observer = rules[selector];
      var sels = selector.split(',');
      sels.each(function(sel) {
        var parts = sel.split(/:(?=[a-z]+$)/), css = parts[0], event =
parts[1];
        $$(css).each(function(element) {
          if (event) {
            observer = Event.addBehavior._wrapObserver(observer);
            $(element).observe(event, observer);
            Event.addBehavior.cache.push([element, event, observer]);
          } else {
            if (!element.$$assigned || !element.$$assigned.include
(observer)) {
              if (observer.attach) observer.attach(element);

              else observer.call($(element));
              element.$$assigned = element.$$assigned || [];
              element.$$assigned.push(observer);
            }
          }
        });
      });
    }
  },

the call to observer = Event.addBehavior._wrapObserver(observer);
means that observer is wrapped with itself, and then in the next
iteration,  you are wrapping the already wrapped observer..Therefore
observer.call() will run observer.call() (etc etc)
surely the fix is to run
observer = Event.addBehavior._wrapObserver(rules[selector])
instead?
It worked for me..let me know what you think

On 5 May, 12:44, Ro <rohittriv...@gmail.com> wrote:


    Reply to author    Forward  
You must Sign in before you can post messages.
To post a message, you must first join this group.
Please update your nickname on the subscription settings page before posting.
You do not have the permission required to post.
Dan Webb  
View profile   Translate to Translated (View Original)
 More options 5 May, 16:29
From: Dan Webb <d...@danwebb.net>
Date: Tue, 5 May 2009 08:29:38 -0700
Local: Tues 5 May 2009 16:29
Subject: Re: low pro "too much recursion"
Thanks for finding this bug.  I'll fix it now.

Cheers,

Dan

On Tue, May 5, 2009 at 8:26 AM, Ro <rohittriv...@gmail.com> wrote:

> Ok - I think I have found the issue.

--
Dan Webb
http://massiverobot.co.uk
http://www.danwebb.net

aim: danwrong123
twitter/skype: danwrong


    Reply to author    Forward  
You must Sign in before you can post messages.
To post a message, you must first join this group.
Please update your nickname on the subscription settings page before posting.
You do not have the permission required to post.
MRoderick  
View profile   Translate to Translated (View Original)
 More options 5 May, 16:32
From: MRoderick <roderick.mor...@gmail.com>
Date: Tue, 5 May 2009 08:32:58 -0700 (PDT)
Local: Tues 5 May 2009 16:32
Subject: Re: low pro "too much recursion"
I think you've cracked it!

There is some work going on for the load method in the alternate forks
of Low Pro.

I will try to incorporate your changes remove this problem when I work
on the load method again and then try to get the other forks to accept
the changes, unless someone beats me to it ;-)


    Reply to author    Forward  
You must Sign in before you can post messages.
To post a message, you must first join this group.
Please update your nickname on the subscription settings page before posting.
You do not have the permission required to post.
MRoderick  
View profile   Translate to Translated (View Original)
 More options 5 May, 16:39
From: MRoderick <roderick.mor...@gmail.com>
Date: Tue, 5 May 2009 08:39:39 -0700 (PDT)
Local: Tues 5 May 2009 16:39
Subject: Re: low pro "too much recursion"
On 5 May, 17:32, MRoderick <roderick.mor...@gmail.com> wrote:

> I think you've cracked it!

> There is some work going on for the load method in the alternate forks
> of Low Pro.

> I will try to incorporate your changes remove this problem when I work
> on the load method again and then try to get the other forks to accept
> the changes, unless someone beats me to it ;-)

Hah, the man himself beat me to it :-)

    Reply to author    Forward  
You must Sign in before you can post messages.
To post a message, you must first join this group.
Please update your nickname on the subscription settings page before posting.
You do not have the permission required to post.
Ro  
View profile   Translate to Translated (View Original)
 More options 6 May, 10:04
From: Ro <rohittriv...@gmail.com>
Date: Wed, 6 May 2009 02:04:36 -0700 (PDT)
Local: Wed 6 May 2009 10:04
Subject: Re: low pro "too much recursion"
cool - no worries - always nice to help! It's a very useful library -
we use it for our project (built on tapestry 5 IOC)

On 5 May, 16:39, MRoderick <roderick.mor...@gmail.com> wrote:


    Reply to author    Forward  
You must Sign in before you can post messages.
To post a message, you must first join this group.
Please update your nickname on the subscription settings page before posting.
You do not have the permission required to post.
End of messages
« Back to Discussions « Newer topic     Older topic »

Create a group - Google Groups - Google Home - Terms of Service - Privacy Policy
©2009 Google