Google Mail Calendar Documents Reader Web more »
Recently Visited Groups | Help | Sign in
Google Groups Home
linux.kernel
+ new post
About this group
Subscribe to this group
This is a Usenet group - learn more
Message from discussion atkb: supress repeated warning messages
The group you are posting to is a Usenet group. Messages posted to this group will make your email address visible to anyone on the Internet.
Your reply message has not been sent.
Your post was successful
 
From:
To:
Cc:
Follow-up To:
Add Cc | Add Follow-up to | Edit Subject
Subject:
Validation:
For verification purposes please type the characters you see in the picture below or the numbers you hear by clicking the accessibility icon. Listen and type the numbers that you hear
 
Alan J. Wylie  
View profile   Translate to Translated (View Original)
 More options 5 Dec 2006, 20:40
Newsgroups: linux.kernel
From: "Alan J. Wylie" <a...@wylie.me.uk>
Date: Tue, 05 Dec 2006 21:40:11 +0100
Local: Tues 5 Dec 2006 20:40
Subject: [PATCH 2.6.19 1/1] atkb: supress repeated warning messages
Reply to author | Forward | Print | View thread | Show original | Report this message | Find messages by this author
On Sat, 2 Dec 2006 13:56:13 +0000, "Alan J. Wylie" <a...@wylie.me.uk> said:

> I was presented with a continous stream of error messages:
> atkbd.c: Spurious ACK on isa0060/serio Some program might be trying
> to access hardware directly.
> These seem to be as a result of the keyboard LEDs being flashed.
> They cause the real error message:
> Cannot open root device
> and the preceding kernel messages which show a lack of detection of
> the SATA hard drive to be rapidly scrolled off screen.
> The atkbd message should at the very least be rate limited.

Here is an ugly hack that limits the above error message.

--- linux/drivers/input/keyboard/atkbd.c.orig   2006-12-05 20:34:50.000000000 +0000
+++ linux/drivers/input/keyboard/atkbd.c        2006-12-03 13:43:13.000000000 +0000
@@ -412,9 +412,16 @@
                        goto out;
                case ATKBD_RET_ACK:
                case ATKBD_RET_NAK:
-                       printk(KERN_WARNING "atkbd.c: Spurious %s on %s. "
-                              "Some program might be trying access hardware directly.\n",
-                              data == ATKBD_RET_ACK ? "ACK" : "NAK", serio->phys);
+                       {
+                               static int warned = 0;
+
+                               if (!warned) {
+                                       printk(KERN_WARNING "atkbd.c: Spurious %s on %s. "
+                                              "Some program might be trying access hardware directly.\n",
+                                              data == ATKBD_RET_ACK ? "ACK" : "NAK", serio->phys);
+                                       warned = 1;
+                               }
+                       }
                        goto out;
                case ATKBD_RET_HANGEUL:
                case ATKBD_RET_HANJA:

Signed-off-by: Alan J. Wylie <a...@wylie.me.uk>

--
Alan J. Wylie                                          http://www.wylie.me.uk/
"Perfection [in design] is achieved not when there is nothing left to add,
but rather when there is nothing left to take away."
  -- Antoine de Saint-Exupery
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/


    Reply to author    Forward  
You must Sign in before you can post messages.
To post a message, you must first join this group.
Please update your nickname on the subscription settings page before posting.
You do not have the permission required to post.
Create a group - Google Groups - Google Home - Terms of Service - Privacy Policy
©2009 Google