Web Images Videos Maps News Shopping Google Mail more »
Recently Visited Groups | Help | Sign in
Google Groups Home
doctrine-svn
Home
Pages
Files
About this group
Join this group
#1704: Searchable behavior bug when primary key is not an integer
Options
There are currently too many topics in this group that display first. To make this topic appear first, remove this option from another topic.
There was an error processing your request. Please try again.
flag
   5 messages - Collapse all  -  Translate all to Translated (View all originals)
The group you are posting to is a Usenet group. Messages posted to this group will make your email address visible to anyone on the Internet.
Your reply message has not been sent.
Your post was successful
 
From:
To:
Cc:
Follow-up To:
Add Cc | Add Follow-up to | Edit Subject
Subject:
Validation:
For verification purposes please type the characters you see in the picture below or the numbers you hear by clicking the accessibility icon. Listen and type the numbers that you hear
 
Doctrine  
View profile   Translate to Translated (View Original)
 More options 1 Dec 2008, 04:05
From: "Doctrine" <no-re...@phpdoctrine.org>
Date: Mon, 01 Dec 2008 04:05:26 -0000
Local: Mon 1 Dec 2008 04:05
Subject: [Doctrine] #1704: Searchable behavior bug when primary key is not an integer
Reply to author | Forward | Print | Individual message | Show original | Report this message | Find messages by this author
#1704: Searchable behavior bug when primary key is not an integer
-----------------------------------+--------------------------------------- -
 Reporter:  ctigglet               |       Owner:  jwage
     Type:  defect                 |      Status:  new  
 Priority:  minor                  |   Milestone:      
Component:  Searchable             |     Version:  1.0.3
 Keywords:                         |    Has_test:  0    
 Mystatus:  Pending Core Response  |   Has_patch:  1    
-----------------------------------+--------------------------------------- -
 I discovered a bug where the Searchable behavior fails if the primary key
 is anything other than an integer.  I tracked the bug down and created the
 attached patch.

--
Ticket URL: <http://trac.doctrine-project.org/ticket/1704>
Doctrine <http://www.phpdoctrine.org>
PHP Doctrine Object Relational Mapper


    Reply to author    Forward  
You must Sign in before you can post messages.
To post a message, you must first join this group.
Please update your nickname on the subscription settings page before posting.
You do not have the permission required to post.
Discussion subject changed to "#1704: [PATCH] Searchable behavior bug when primary key is not an integer (was: Searchable behavior bug when primary key is not an integer)" by Doctrine
Doctrine  
View profile   Translate to Translated (View Original)
 More options 1 Dec 2008, 13:55
From: "Doctrine" <no-re...@phpdoctrine.org>
Date: Mon, 01 Dec 2008 13:55:12 -0000
Local: Mon 1 Dec 2008 13:55
Subject: Re: [Doctrine] #1704: [PATCH] Searchable behavior bug when primary key is not an integer (was: Searchable behavior bug when primary key is not an integer)
Reply to author | Forward | Print | Individual message | Show original | Report this message | Find messages by this author
#1704: [PATCH] Searchable behavior bug when primary key is not an integer
-----------------------------------+--------------------------------------- -
 Reporter:  ctigglet               |       Owner:  jwage
     Type:  defect                 |      Status:  new  
 Priority:  minor                  |   Milestone:      
Component:  Searchable             |     Version:  1.0.3
 Keywords:                         |    Has_test:  0    
 Mystatus:  Pending Core Response  |   Has_patch:  1    
-----------------------------------+--------------------------------------- -

--
Ticket URL: <http://trac.doctrine-project.org/ticket/1704#comment:1>
Doctrine <http://www.phpdoctrine.org>
PHP Doctrine Object Relational Mapper


    Reply to author    Forward  
You must Sign in before you can post messages.
To post a message, you must first join this group.
Please update your nickname on the subscription settings page before posting.
You do not have the permission required to post.
Discussion subject changed to "#1704: [PATCH] Searchable behavior bug when primary key is not an integer" by Doctrine
Doctrine  
View profile   Translate to Translated (View Original)
 More options 1 Dec 2008, 15:33
From: "Doctrine" <no-re...@phpdoctrine.org>
Date: Mon, 01 Dec 2008 15:33:17 -0000
Local: Mon 1 Dec 2008 15:33
Subject: Re: [Doctrine] #1704: [PATCH] Searchable behavior bug when primary key is not an integer
Reply to author | Forward | Print | Individual message | Show original | Report this message | Find messages by this author
#1704: [PATCH] Searchable behavior bug when primary key is not an integer
-----------------------------------+--------------------------------------- -
 Reporter:  ctigglet               |       Owner:  jwage
     Type:  defect                 |      Status:  new  
 Priority:  minor                  |   Milestone:      
Component:  Searchable             |     Version:  1.0.3
 Keywords:                         |    Has_test:  0    
 Mystatus:  Pending Core Response  |   Has_patch:  1    
-----------------------------------+--------------------------------------- -

Comment(by romanb):

 I think the original implementation as well as the patch are flawed. I
 dont think databases other than mysql will allow numeric values to be
 quoted. A proper solution would be to construct a prepared statement and
 bind the parameters.

--
Ticket URL: <http://trac.doctrine-project.org/ticket/1704#comment:2>
Doctrine <http://www.phpdoctrine.org>
PHP Doctrine Object Relational Mapper


    Reply to author    Forward  
You must Sign in before you can post messages.
To post a message, you must first join this group.
Please update your nickname on the subscription settings page before posting.
You do not have the permission required to post.
Doctrine  
View profile   Translate to Translated (View Original)
 More options 1 Dec 2008, 16:06
From: "Doctrine" <no-re...@phpdoctrine.org>
Date: Mon, 01 Dec 2008 16:06:14 -0000
Local: Mon 1 Dec 2008 16:06
Subject: Re: [Doctrine] #1704: [PATCH] Searchable behavior bug when primary key is not an integer
Reply to author | Forward | Print | Individual message | Show original | Report this message | Find messages by this author
#1704: [PATCH] Searchable behavior bug when primary key is not an integer
-----------------------------------+--------------------------------------- -
 Reporter:  ctigglet               |       Owner:  jwage
     Type:  defect                 |      Status:  new  
 Priority:  minor                  |   Milestone:      
Component:  Searchable             |     Version:  1.0.3
 Keywords:                         |    Has_test:  0    
 Mystatus:  Pending Core Response  |   Has_patch:  1    
-----------------------------------+--------------------------------------- -

Comment(by ctigglet):

 I went back and did as you suggested and made it into a prepared statement
 but not sure I did it in a way that is acceptable.

--
Ticket URL: <http://trac.doctrine-project.org/ticket/1704#comment:3>
Doctrine <http://www.phpdoctrine.org>
PHP Doctrine Object Relational Mapper


    Reply to author    Forward  
You must Sign in before you can post messages.
To post a message, you must first join this group.
Please update your nickname on the subscription settings page before posting.
You do not have the permission required to post.
Doctrine  
View profile   Translate to Translated (View Original)
 More options 2 Dec 2008, 02:44
From: "Doctrine" <no-re...@phpdoctrine.org>
Date: Tue, 02 Dec 2008 02:44:07 -0000
Local: Tues 2 Dec 2008 02:44
Subject: Re: [Doctrine] #1704: [PATCH] Searchable behavior bug when primary key is not an integer
Reply to author | Forward | Print | Individual message | Show original | Report this message | Find messages by this author
#1704: [PATCH] Searchable behavior bug when primary key is not an integer
-----------------------------------+--------------------------------------- -
 Reporter:  ctigglet               |       Owner:  jwage
     Type:  defect                 |      Status:  new  
 Priority:  minor                  |   Milestone:  1.0.5
Component:  Searchable             |     Version:  1.0.3
 Keywords:                         |    Has_test:  0    
 Mystatus:  Pending Core Response  |   Has_patch:  1    
-----------------------------------+--------------------------------------- -
Changes (by jwage):

  * milestone:  => 1.0.5

--
Ticket URL: <http://trac.phpdoctrine.org/ticket/1704#comment:4>
Doctrine <http://www.phpdoctrine.org>
PHP Doctrine Object Relational Mapper


    Reply to author    Forward  
You must Sign in before you can post messages.
To post a message, you must first join this group.
Please update your nickname on the subscription settings page before posting.
You do not have the permission required to post.
End of messages
« Back to Discussions « Newer topic     Older topic »

Google Groups - Google Home - Terms of Service - Privacy Policy
©2009 Google