mapValue - documentation incorrect - doctrine-dev

Message from discussion mapValue - documentation incorrect
Received-SPF: pass (google.com: domain of adam.hutt...@fracturedatlas.org designates 206.71.147.202 as permitted sender) client-ip=206.71.147.202;
From: "Adam Huttler" <adam.hutt...@fracturedatlas.org>
To: <doctrine-dev@googlegroups.com>
References: <-1743492932806318323@unknownmsgid> <be85b5220906250553o7af0b4d9m60f3c426909fd431@mail.gmail.com>
In-Reply-To: <be85b5220906250553o7af0b4d9m60f3c426909fd431@mail.gmail.com>
Subject: RE: [doctrine-dev] Re: mapValue - documentation incorrect
Date: Thu, 25 Jun 2009 09:34:26 -0400 (EDT)
Message-ID: <00bf01c9f59a$26f3f260$74dbd720$@huttler@fracturedatlas.org>
Mime-Version: 1.0
Content-Type: multipart/alternative;
	boundary="----=_NextPart_000_00C0_01C9F578.9FE25260"
Thread-Index: Acn1k3sJIgY4ZkbRTiem1mLjJURU0QABqgtw
Content-Language: en-us

------=_NextPart_000_00C0_01C9F578.9FE25260
Content-Type: text/plain

Done:

http://trac.doctrine-project.org/ticket/2287

 

 

From: doctrine-dev@googlegroups.com [mailto:doctrine-dev@googlegroups.com]
On Behalf Of Jonathan Wage
Sent: Thursday, June 25, 2009 8:53 AM
To: doctrine-dev@googlegroups.com
Subject: [doctrine-dev] Re: mapValue - documentation incorrect

 

Can you log a ticket for this if you don't mind?

Thanks, Jon

On Wed, Jun 24, 2009 at 10:57 AM, Adam Huttler
<adam.hutt...@fracturedatlas.org> wrote:

Hi,

The documentation for mapping custom values is incorrect:
http://www.doctrine-project.org/documentation/manual/1_1/en/component-over
view#record:mapping-custom-values

The example in the docs shows $this->mapValue() being called in
setTableDefinition(), but that doesn't work. It needs to be called in
construct() for it to work correctly.

Having said that, I think this is the wrong approach. Doesn't it make more
sense to define a custom property in setTableDefinition(), alongside all
of the regular columns?

Thanks,
Adam

 

 




-- 
Jonathan H. Wage (+1 415 992 5468)
Open Source Software Developer & Evangelist
sensiolabs.com | jwage.com | doctrine-project.org | symfony-project.org

You can contact Jonathan about Doctrine, Symfony and Open-Source or for
training, consulting, application development, or business related
questions at jonathan.w...@sensio.com



------=_NextPart_000_00C0_01C9F578.9FE25260
Content-Type: text/html
Content-Transfer-Encoding: quoted-printable

<html xmlns:v=3D"urn:schemas-microsoft-com:vml" xmlns:o=3D"urn:schemas-micr=
osoft-com:office:office" xmlns:w=3D"urn:schemas-microsoft-com:office:word" =
xmlns:x=3D"urn:schemas-microsoft-com:office:excel" xmlns:p=3D"urn:schemas-m=
icrosoft-com:office:powerpoint" xmlns:a=3D"urn:schemas-microsoft-com:office=
:access" xmlns:dt=3D"uuid:C2F41010-65B3-11d1-A29F-00AA00C14882" xmlns:s=3D"=
uuid:BDC6E3F0-6DA3-11d1-A2A3-00AA00C14882" xmlns:rs=3D"urn:schemas-microsof=
t-com:rowset" xmlns:z=3D"#RowsetSchema" xmlns:b=3D"urn:schemas-microsoft-co=
m:office:publisher" xmlns:ss=3D"urn:schemas-microsoft-com:office:spreadshee=
t" xmlns:c=3D"urn:schemas-microsoft-com:office:component:spreadsheet" xmlns=
:odc=3D"urn:schemas-microsoft-com:office:odc" xmlns:oa=3D"urn:schemas-micro=
soft-com:office:activation" xmlns:html=3D"http://www.w3.org/TR/REC-html40" =
xmlns:q=3D"http://schemas.xmlsoap.org/soap/envelope/" xmlns:rtc=3D"http://m=
icrosoft.com/officenet/conferencing" xmlns:D=3D"DAV:" xmlns:Repl=3D"http://=
schemas.microsoft.com/repl/" xmlns:mt=3D"http://schemas.microsoft.com/share=
point/soap/meetings/" xmlns:x2=3D"http://schemas.microsoft.com/office/excel=
/2003/xml" xmlns:ppda=3D"http://www.passport.com/NameSpace.xsd" xmlns:ois=
=3D"http://schemas.microsoft.com/sharepoint/soap/ois/" xmlns:dir=3D"http://=
schemas.microsoft.com/sharepoint/soap/directory/" xmlns:ds=3D"http://www.w3=
.org/2000/09/xmldsig#" xmlns:dsp=3D"http://schemas.microsoft.com/sharepoint=
/dsp" xmlns:udc=3D"http://schemas.microsoft.com/data/udc" xmlns:xsd=3D"http=
://www.w3.org/2001/XMLSchema" xmlns:sub=3D"http://schemas.microsoft.com/sha=
repoint/soap/2002/1/alerts/" xmlns:ec=3D"http://www.w3.org/2001/04/xmlenc#"=
 xmlns:sp=3D"http://schemas.microsoft.com/sharepoint/" xmlns:sps=3D"http://=
schemas.microsoft.com/sharepoint/soap/" xmlns:xsi=3D"http://www.w3.org/2001=
/XMLSchema-instance" xmlns:udcs=3D"http://schemas.microsoft.com/data/udc/so=
ap" xmlns:udcxf=3D"http://schemas.microsoft.com/data/udc/xmlfile" xmlns:udc=
p2p=3D"http://schemas.microsoft.com/data/udc/parttopart" xmlns:wf=3D"http:/=
/schemas.microsoft.com/sharepoint/soap/workflow/" xmlns:dsss=3D"http://sche=
mas.microsoft.com/office/2006/digsig-setup" xmlns:dssi=3D"http://schemas.mi=
crosoft.com/office/2006/digsig" xmlns:mdssi=3D"http://schemas.openxmlformat=
s.org/package/2006/digital-signature" xmlns:mver=3D"http://schemas.openxmlf=
ormats.org/markup-compatibility/2006" xmlns:m=3D"http://schemas.microsoft.c=
om/office/2004/12/omml" xmlns:mrels=3D"http://schemas.openxmlformats.org/pa=
ckage/2006/relationships" xmlns:spwp=3D"http://microsoft.com/sharepoint/web=
partpages" xmlns:ex12t=3D"http://schemas.microsoft.com/exchange/services/20=
06/types" xmlns:ex12m=3D"http://schemas.microsoft.com/exchange/services/200=
6/messages" xmlns:pptsl=3D"http://schemas.microsoft.com/sharepoint/soap/Sli=
deLibrary/" xmlns:spsl=3D"http://microsoft.com/webservices/SharePointPortal=
Server/PublishedLinksService" xmlns:Z=3D"urn:schemas-microsoft-com:" xmlns:=
st=3D"&#1;" xmlns=3D"http://www.w3.org/TR/REC-html40">

<head>
<META HTTP-EQUIV=3D"Content-Type" CONTENT=3D"text/html; charset=3Dus-ascii"=
>
<meta name=3DGenerator content=3D"Microsoft Word 12 (filtered medium)">
<style>
<!--
 /* Font Definitions */
 @font-face
	{font-family:"Cambria Math";
	panose-1:2 4 5 3 5 4 6 3 2 4;}
@font-face
	{font-family:Calibri;
	panose-1:2 15 5 2 2 2 4 3 2 4;}
@font-face
	{font-family:Tahoma;
	panose-1:2 11 6 4 3 5 4 4 2 4;}
 /* Style Definitions */
 p.MsoNormal, li.MsoNormal, div.MsoNormal
	{margin:0in;
	margin-bottom:.0001pt;
	font-size:12.0pt;
	font-family:"Times New Roman","serif";}
a:link, span.MsoHyperlink
	{mso-style-priority:99;
	color:blue;
	text-decoration:underline;}
a:visited, span.MsoHyperlinkFollowed
	{mso-style-priority:99;
	color:purple;
	text-decoration:underline;}
p
	{mso-style-priority:99;
	mso-margin-top-alt:auto;
	margin-right:0in;
	mso-margin-bottom-alt:auto;
	margin-left:0in;
	font-size:12.0pt;
	font-family:"Times New Roman","serif";}
span.EmailStyle18
	{mso-style-type:personal-reply;
	font-family:"Calibri","sans-serif";
	color:#1F497D;}
.MsoChpDefault
	{mso-style-type:export-only;}
.MsoPapDefault
	{mso-style-type:export-only;
	margin-bottom:10.0pt;}
@page Section1
	{size:8.5in 11.0in;
	margin:1.0in 1.0in 1.0in 1.0in;}
div.Section1
	{page:Section1;}
-->
</style>
<!--[if gte mso 9]><xml>
 <o:shapedefaults v:ext=3D"edit" spidmax=3D"1026" />
</xml><![endif]--><!--[if gte mso 9]><xml>
 <o:shapelayout v:ext=3D"edit">
  <o:idmap v:ext=3D"edit" data=3D"1" />
 </o:shapelayout></xml><![endif]-->
</head>

<body lang=3DEN-US link=3Dblue vlink=3Dpurple>

<div class=3DSection1>

<p class=3DMsoNormal><span style=3D'font-size:11.0pt;font-family:"Calibri",=
"sans-serif";
color:#1F497D'>Done:<o:p></o:p></span></p>

<p class=3DMsoNormal><span style=3D'font-size:11.0pt;font-family:"Calibri",=
"sans-serif";
color:#1F497D'><a href=3D"http://trac.doctrine-project.org/ticket/2287">htt=
p://trac.doctrine-project.org/ticket/2287</a><o:p></o:p></span></p>

<p class=3DMsoNormal><span style=3D'font-size:11.0pt;font-family:"Calibri",=
"sans-serif";
color:#1F497D'><o:p>&nbsp;</o:p></span></p>

<p class=3DMsoNormal><span style=3D'font-size:11.0pt;font-family:"Calibri",=
"sans-serif";
color:#1F497D'><o:p>&nbsp;</o:p></span></p>

<div style=3D'border:none;border-left:solid blue 1.5pt;padding:0in 0in 0in =
4.0pt'>

<div>

<div style=3D'border:none;border-top:solid #B5C4DF 1.0pt;padding:3.0pt 0in =
0in 0in'>

<p class=3DMsoNormal><b><span style=3D'font-size:10.0pt;font-family:"Tahoma=
","sans-serif"'>From:</span></b><span
style=3D'font-size:10.0pt;font-family:"Tahoma","sans-serif"'>
doctrine-dev@googlegroups.com [mailto:doctrine-dev@googlegroups.com] <b>On
Behalf Of </b>Jonathan Wage<br>
<b>Sent:</b> Thursday, June 25, 2009 8:53 AM<br>
<b>To:</b> doctrine-dev@googlegroups.com<br>
<b>Subject:</b> [doctrine-dev] Re: mapValue - documentation incorrect<o:p><=
/o:p></span></p>

</div>

</div>

<p class=3DMsoNormal><o:p>&nbsp;</o:p></p>

<p class=3DMsoNormal style=3D'margin-bottom:12.0pt'>Can you log a ticket fo=
r this
if you don't mind?<br>
<br>
Thanks, Jon<o:p></o:p></p>

<div>

<p class=3DMsoNormal style=3D'margin-bottom:10.0pt'>On Wed, Jun 24, 2009 at=
 10:57
AM, Adam Huttler &lt;<a href=3D"mailto:adam.hutt...@fracturedatlas.org">ada=
m.hutt...@fracturedatlas.org</a>&gt;
wrote:<o:p></o:p></p>

<div>

<div>

<p>Hi,<o:p></o:p></p>

<p>The documentation for mapping custom values is incorrect:<br>
<a
href=3D"http://www.doctrine-project.org/documentation/manual/1_1/en/compone=
nt-overview#record:mapping-custom-values"
target=3D"_blank">http://www.doctrine-project.org/documentation/manual/1_1/=
en/component-overview#record:mapping-custom-values</a><o:p></o:p></p>

<p>The example in the docs shows $this-&gt;mapValue() being called in
setTableDefinition(), but that doesn&#8217;t work. It needs to be called in=
 construct()
for it to work correctly.<o:p></o:p></p>

<p>Having said that, I think this is the wrong approach. Doesn&#8217;t it m=
ake more
sense to define a custom property in setTableDefinition(), alongside all of=
 the
regular columns?<o:p></o:p></p>

<p>Thanks,<br>
Adam<o:p></o:p></p>

</div>

<p class=3DMsoNormal><o:p>&nbsp;</o:p></p>

</div>

<p class=3DMsoNormal><o:p>&nbsp;</o:p></p>

</div>

<p class=3DMsoNormal style=3D'margin-bottom:12.0pt'><br>
<br clear=3Dall>
<br>
-- <br>
Jonathan H. Wage (+1 415 992 5468)<br>
Open Source Software Developer &amp; Evangelist<br>
<a href=3D"http://sensiolabs.com">sensiolabs.com</a> | <a href=3D"http://jw=
age.com">jwage.com</a>
| <a href=3D"http://doctrine-project.org">doctrine-project.org</a> | <a
href=3D"http://symfony-project.org">symfony-project.org</a><br>
<br>
You can contact Jonathan about Doctrine, Symfony and Open-Source or for
training, consulting, application development, or business related question=
s at
<a href=3D"mailto:jonathan.w...@sensio.com">jonathan.w...@sensio.com</a><br=
>
<br>

</div>

</div>

</body>

</html>

------=_NextPart_000_00C0_01C9F578.9FE25260--