Port my ray tracer - comp.lang.functional

Message from discussion Port my ray tracer

Vesa Karvonen

View profile

More options 2 Jun 2005, 16:05

Newsgroups: comp.lang.functional

From: Vesa Karvonen <vesa.karvo...@cs.helsinki.fi>

Date: 2 Jun 2005 15:05:33 GMT

Local: Thurs 2 Jun 2005 16:05

Subject: Re: Port my ray tracer

  Reply to author
  |
  Forward | Print | View thread
  | Show original
  | Report this message | Find messages by this author
  

Jon Harrop <use...@jdh30.plus.com> wrote:

[...]

> I'm keen to hear any constructive criticisms of my existing
> implementations.
[...]
> let val r' = 3.0 * r / Real.Math.sqrt 12.0 in
> let fun aux x' z' =
> create (level-1) (0.5 * r) (x-x', y+r', z+z') in
> let val objs = [aux (~r') (~r'), aux r' (~r'),
> aux (~r') r', aux r' r', obj] in
> Group ((x, y, z), 3.0 * r, objs)
> end end end end

[...]

This won't have an effect on performance, but the above style of
let-nesting (used throughout the code), which is probably a result of
a conservative translating from OCaml, is not necessary in SML. In
SML, you can flatten the nested let-expressions. In other words, you
can flatten an expression of the form

let val ... in
let val ... in
...
let val in ... end ... end end

into

let val ...
val ...
...
in ... end

-Vesa Karvonen

Reply to author Forward